Add lodash cloneDeep to support arrays in omitPaths #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and unit test with the case.
MiguelNazMor
changed the title
willfarrell
reviewed
Aug 29, 2020
| @@ -9,7 +10,8 @@ module.exports = (opts) => { | |||
| const { logger, omitPaths } = Object.assign({}, defaults, opts) | |||
|
|
|||
| const omitAndLog = message => { | |||
| const redactedMessage = omit(message, omitPaths) | |||
| const messageClone = cloneDeep(message) | |||
There was a problem hiding this comment.
Can you test using JSON.parse(JSON.stringify(o)) instead. _.cloneDeep is notoriously slow in comparison, unless you're using the additional edge cases.
There was a problem hiding this comment.
Updated and tested, thanks for your comment!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and unit test with the case.
(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)
What does this implement/fix? Explain your changes.
While working with the middleware I discovered that, when adding a path to omitPaths which is apart of an array ("response.users[0].email"), the field was deleted form the log but also from the response.
Using cloneDeep fixes this behaviour (unit test added).
Does this close any currently open issues?
…
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?
Node.js Versions: …
--12.4--
Middy Versions: …
AWS SDK Versions: …
Todo list
[ X] Feature/Fix fully implemented
[ X] Added tests
[ NA] Updated relevant documentation
[ NA] Updated relevant examples